7.0 orm.py raises exeption on write -> split_for_in_conditions has changed !

orm openerp7.0

2 Svar

5428 Vyer

Joeri Belis

I installed latest 7 release from github. But were i had no problem with an older codebase of 7, i now ran into an exception raised in orm.py.

When i do a write in my custom module, orm.pay raises

File "/home/openerp/openerp/odoo/openerp/addons/base/res/res_partner.py", line 536, in write

result = super(res_partner,self).write(cr, uid, ids, vals, context=context)

File "/home/openerp/openerp/odoo/openerp/addons/mail/mail_thread.py", line 297, in write

result = super(mail_thread, self).write(cr, uid, ids, values, context=context)

File "/home/openerp/openerp/odoo/openerp/osv/orm.py", line 4276, in write

_('One of the records you are trying to modify has already been deleted (Document type: %s).') % self._description)

It all comes down to this piece of code in the orm.py. The

cr.rowcount != len(sub_ids)

What could be a reason why the update would give a different rowcount vs the ids i need to update

 if len(upd0):
        self.check_access_rule(cr, user, ids, 'write', context=context)
        for sub_ids in cr.split_for_in_conditions(ids):
            cr.execute('update ' + self._table + ' set ' + ','.join(upd0) + ' ' \
                       'where id IN %s', upd1 + [sub_ids])
            if cr.rowcount != len(sub_ids):
                raise except_orm(_('AccessError'),
                                 _('One of the records you are trying to modify has already been deleted (Document type: %s).') % self._description)

Axel Mendoza

post more about your scenario, like something of how to reproduce your bug

Joeri Belis

Författare

Debugging some more i found that my ids have doubles in the list of ids

That would explain why the result from cr.rowcount = 997 and i have 1000 ids. the 3 doubles.

This is because split_for_in_conditions in sql_db.py changed between versions

from

    def split_for_in_conditions(self, ids):
        """Split a list of identifiers into one or more smaller tuples
           safe for IN conditions, after uniquifying them."""
        return tools.misc.split_every(self.IN_MAX, set(ids))

to:

    def split_for_in_conditions(self, ids):
        """Split a list of identifiers into one or more smaller tuples
           safe for IN conditions, after uniquifying them."""
        return tools.misc.split_every(self.IN_MAX, ids)

They removed the set() !

But any idea when and why this feature got changed!

And do i need to change my code to handle doubles in a list of ids i want to update?

or is this a bug that odoo is going to fix lowlevel?

Joeri Belis

Författare

[FIX] orm: ordering on >1000 records … https://github.com/odoo/odoo/commit/cb5f00f58016d087cf5387c3eadf9144f45a0397

Njuter du av diskussionen? Läs inte bara, delta också!

Skapa ett konto idag för att ta del av exklusiva funktioner och engagera dig i vår fantastiska community!

Registrera dig

Relaterade inlägg	Svar	Vyer
Education or School Management module is available for openerp 7.0? Löst openerp7.0	2 feb. 24	30548
Security (6,0) and (4) in openerp Löst openerp7.0	3 dec. 25	59278
Prestashop Odoo openerp7.0	0 juli 22	3035
ORM Relationship in Odoo 12 orm	0 sep. 19	98
Move or forward emails from Sales Pipeline to original Email Account openerp7.0	0 sep. 17	5292

Denna fråga har flaggats

Njuter du av diskussionen? Läs inte bara, delta också!