Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Artificial Intelligence
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Property Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

[v13] Update one2many field after a change in its parent

Subscribe

Get notified when there's activity on this post

This question has been flagged
one2manyonchangeparentOdoo13.0v13
2 Replies
9970 Views
Avatar
Víctor

I'm trying to apply a global discount to invoices (v13). I don't want to modify the way Odoo calculates the invoice amount, so all I'm doing is change the discount field for every account.move.line of the invoice.

I create the global_discount field in account.move:​

class AccountMove(models.Model):
_inherit = 'account.move'

global_discount = fields.Float(string='Global Discount (%)', digits='Discount', default=0.0)
​

Now, I want to change the discount field when global_discount is modified, but @api.onchange is not being called when doing so. It doesn't work adding either the parent reference or a related field to the decorator:

class AccountMoveLine(models.Model):
_inherit = 'account.move.line'

global_discount = fields.Float(related='move_id.global_discount')

# This method is not being called when changing global_discount
@api.onchange('move_id.global_discount', 'global_discount')
def _compute_discount(self):
for line in self:
# Simplified for easy reading, I'm not actually doing this
line.discount = line.global_discount

Even if I make discount a computed field and use @api.depends, its onchange methods won't be called.
If I modify the lines from an onchange method in the parent, the discount onchange methods won't be called and  price_subtotal will not change:

class AccountMove(models.Model):
_inherit = 'account.move'

@api.onchange('global_discount')
def _compute_discount(self):
for invoice in self:
for line in invoice.invoice_line_ids:
line._compute_discount()

I have also tried calling the onchange methods manually, but I'm definitely doing something wrong because nothing new happens:

@api.onchange('global_discount')
def _compute_discount(self):
for invoice in self:
for line in invoice.invoice_line_ids:
line._compute_discount()
spec = line._onchange_spec()
values = dict(line._cache)

# onchange returns and empty dict {}
updates = line.onchange(values, 'discount', spec)

value = updates.get('value', {})

for name, val in value.items():
if isinstance(val, tuple):
value[name] = val[0]

values.update(value)
line.update(values)

I'm missing something on how Odoo calls onchange methods from python, but I can't figure it out.

0
Avatar
Discard
Avatar
Víctor
Author Best Answer

I had to call _move_autocomplete_invoice_lines_values() in the parent move after updating the discount for the changes to be propagated.

0
Avatar
Discard
Avatar
Ibrahim ALdaw
Best Answer

 in account.move  use this Methods Instead:

    @api.onchange('global_discount')
def _compute_discount(self):
for line in self.invoice_line_ids:
line.update({'discount':self.global_discount})
0
Avatar
Discard
Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
On change is not triggered Solved
one2many onchange Odoo13.0
Avatar
Avatar
1
Jan 21
7516
Many2one dependant booleans Solved
onchange Odoo13.0 v13
Avatar
Avatar
1
Dec 19
4659
fill a field up based on domain condition Solved
onchange Odoo13.0
Avatar
Avatar
Avatar
5
Dec 22
7593
One2many-field based on value in many2one-field Solved
one2many Odoo13.0
Avatar
Avatar
1
Jan 21
5081
How to update two levels o2m fileds relation
one2many onchange
Avatar
0
Sep 20
5168
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk Slovenščina Español (América Latina) Español Svenska ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now