Skip to Content
Odoo Menu
  • Sign in
  • Try it free
  • Apps
    Finance
    • Accounting
    • Invoicing
    • Expenses
    • Spreadsheet (BI)
    • Documents
    • Sign
    Sales
    • CRM
    • Sales
    • POS Shop
    • POS Restaurant
    • Subscriptions
    • Rental
    Websites
    • Website Builder
    • eCommerce
    • Blog
    • Forum
    • Live Chat
    • eLearning
    Supply Chain
    • Inventory
    • Manufacturing
    • PLM
    • Purchase
    • Maintenance
    • Quality
    Human Resources
    • Employees
    • Recruitment
    • Time Off
    • Appraisals
    • Referrals
    • Fleet
    Marketing
    • Social Marketing
    • Email Marketing
    • SMS Marketing
    • Events
    • Marketing Automation
    • Surveys
    Services
    • Project
    • Timesheets
    • Field Service
    • Helpdesk
    • Planning
    • Appointments
    Productivity
    • Discuss
    • Artificial Intelligence
    • IoT
    • VoIP
    • Knowledge
    • WhatsApp
    Third party apps Odoo Studio Odoo Cloud Platform
  • Industries
    Retail
    • Book Store
    • Clothing Store
    • Furniture Store
    • Grocery Store
    • Hardware Store
    • Toy Store
    Food & Hospitality
    • Bar and Pub
    • Restaurant
    • Fast Food
    • Guest House
    • Beverage Distributor
    • Hotel
    Real Estate
    • Real Estate Agency
    • Architecture Firm
    • Construction
    • Property Management
    • Gardening
    • Property Owner Association
    Consulting
    • Accounting Firm
    • Odoo Partner
    • Marketing Agency
    • Law firm
    • Talent Acquisition
    • Audit & Certification
    Manufacturing
    • Textile
    • Metal
    • Furnitures
    • Food
    • Brewery
    • Corporate Gifts
    Health & Fitness
    • Sports Club
    • Eyewear Store
    • Fitness Center
    • Wellness Practitioners
    • Pharmacy
    • Hair Salon
    Trades
    • Handyman
    • IT Hardware & Support
    • Solar Energy Systems
    • Shoe Maker
    • Cleaning Services
    • HVAC Services
    Others
    • Nonprofit Organization
    • Environmental Agency
    • Billboard Rental
    • Photography
    • Bike Leasing
    • Software Reseller
    Browse all Industries
  • Community
    Learn
    • Tutorials
    • Documentation
    • Certifications
    • Training
    • Blog
    • Podcast
    Empower Education
    • Education Program
    • Scale Up! Business Game
    • Visit Odoo
    Get the Software
    • Download
    • Compare Editions
    • Releases
    Collaborate
    • Github
    • Forum
    • Events
    • Translations
    • Become a Partner
    • Services for Partners
    • Register your Accounting Firm
    Get Services
    • Find a Partner
    • Find an Accountant
    • Meet an advisor
    • Implementation Services
    • Customer References
    • Support
    • Upgrades
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Get a demo
  • Pricing
  • Help
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Tags (View all)
odoo accounting v14 pos v15
About this forum
Help

POS Custom Promotion Popup: Confirm button not triggering applyPromotions()

Subscribe

Get notified when there's activity on this post

This question has been flagged
pos18.0
1 Reply
1973 Views
Avatar
Nyan Min Htet


I’m developing a custom promotion program for Odoo 18 POS. 

I created a popup (`SelectedPromotionPopup`) where the user can select a promotion and then click **Confirm** to apply it. 


The problem: when I click **Confirm**, nothing happens — my `applyPromotions()` function is not being called.


Here’s a simplified version of the code:

ApplPromotionButton.js

/** @odoo-module */
import { ControlButtons } from "@point_of_sale/app/screens/product_screen/control_buttons/control_buttons";
import { patch } from "@web/core/utils/patch";
import { SelectedPromotionPopup } from "@promotion_program/app/utils/input_popups/SelectedPromotionPopup";
import { _t } from "@web/core/l10n/translation";
import { AlertDialog } from "@web/core/confirmation_dialog/confirmation_dialog";
import { useService } from "@web/core/utils/hooks"; // Ensure useService is imported

patch(ControlButtons.prototype, {
    setup() {
        super.setup(...arguments);
        this.dialog = useService("dialog");
        this.pos = this.env.services.pos;
    },
    async onApplyPromotionClick() {
        const order = this.pos.get_order();
        const promotions = this.pos.promotions || [];

        if (promotions.length > 0) {
            try {
                const { confirmed, payload } = await this.dialog.add(SelectedPromotionPopup, {
                    title: _t("Select Promotions to Apply"),
                    promotions: promotions,
                    confirmText: _t("Apply"),
                    cancelText: _t("Cancel"),
                });
            } catch (error) {
                console.error("Error opening popup:", error);
            }
        } else if (order.orderlines.length > 0) {
            this.dialog.add(AlertDialog, {
                title: _t("No Promotion Available"),
                body: _t("There is no promotion available for the current order!"),
            });
        }
    }
});

SelectedPromotionPopup.js


applyPromotions(willApplyAll) {
    console.log("applyPromotions called");
    this.props.resolve({ confirmed: true, payload: this.state.selectedPromotions });
}

SelectedPromotionPopup.xml

<t t-name="promotion_program.SelectedPromotionPopup">
    <Dialog title="props.title">
        <div class="popup popup-textinput">
            <div class="modal-body">
                <div class="list-group mt-1">
                    <t t-foreach="props.promotions" t-as="promotion" t-key="promotion.id">
                        <div class="list-group-item list-group-item-action d-flex align-items-center"
                             t-att-class="{'selected-item': this.state.selectedPromotionId === promotion.id}"
                             t-attf-id="promotion-item-{{ promotion.id }}"
                             t-att-data-id="promotion.id"
                             t-on-click.prevent="() => this.selectPromotion(promotion.id)">

                            <!-- Icon -->
                            <div class="me-2" style="font-size: 28px;">
                                <i t-if="promotion.type == 'buy_one_get_one'" class="fa fa-gift" style="color:#5B0082"></i>
                                <i t-if="promotion.type == 'discount'" class="fa fa-percent" style="color:#008081"></i>
                                <i t-if="promotion.type == 'free_shipping'" class="fa fa-truck" style="color:#006401"></i>
                            </div>

                            <!-- Text -->
                            <div>
                                <div class="fw-bold">
                                    <t t-esc="promotion.code"/>
                                </div>
                                <div class="text-muted small">
                                    <t t-esc="promotion.description or ''"/>
                                </div>
                            </div>
                        </div>
                    </t>
                </div>
            </div>

            <t t-set-slot="footer">
                <div class="button confirm highlight btn btn-lg btn-primary"
                     t-att-disabled="!this.state.selectedPromotionId"
                     t-on-click.prevent="() => this.applyPromotions()">
                    <t t-esc="props.confirmText" />
                </div>
                <div class="button cancel btn btn-lg btn-secondary" t-on-click="props.cancel">
                    <t t-esc="props.cancelText" />
                </div>
            </t>
        </div>
    </Dialog>
</t>

0
Avatar
Discard
Avatar
Cybrosys Techno Solutions Pvt.Ltd
Best Answer

Hi,


Please try the following,


- Change your t-on-click to directly call the method (without arrow function):


<div class="button confirm highlight btn btn-lg btn-primary"

     t-att-disabled="!this.state.selectedPromotionId"

     t-on-click="applyPromotions">

    <t t-esc="props.confirmText" />

</div>


Also, make sure your JS method is correct


applyPromotions() {

    console.log("applyPromotions called");

    this.props.resolve({

        confirmed: true,

        payload: this.state.selectedPromotionId, // or selectedPromotions if multiple

    });

}


Usage in ApplPromotionButton.js


async onApplyPromotionClick() {

    const { confirmed, payload } = await this.dialog.add(SelectedPromotionPopup, {

        title: _t("Select Promotions to Apply"),

        promotions: this.pos.promotions || [],

        confirmText: _t("Apply"),

        cancelText: _t("Cancel"),

    });


    if (confirmed) {

        console.log("Selected promo:", payload);

        this.applyPromotionToOrder(payload);

    }

}


Hope it helps

0
Avatar
Discard
Nyan Min Htet
Author

It seen like in the applyPromotions() this.props.resolve don't seen to know it as a function cuz i got
Uncaught TypeError: this.props.resolve is not a function

Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Sign up
Related Posts Replies Views Activity
Odoo 18: Price tags in Point of Sale (POS) Solved
pos 18.0
Avatar
Avatar
Avatar
Avatar
Avatar
8
Apr 26
9172
How to print order bill and still have the possibility to make payment.
pos 18.0
Avatar
Avatar
Avatar
Avatar
Avatar
4
Aug 25
4087
How to create a Manufacturing order record from POS order
pos 18.0
Avatar
Avatar
1
Mar 25
3669
Point of Sale - When We redeem points, new points are also added
pos loyalty 18.0
Avatar
Avatar
1
Aug 25
2411
Change the number of loyalty points used in PoS.
pos loyalty 18.0
Avatar
Avatar
1
Nov 24
3958
Community
  • Tutorials
  • Documentation
  • Forum
Open Source
  • Download
  • Github
  • Runbot
  • Translations
Services
  • Odoo.sh Hosting
  • Support
  • Upgrade
  • Custom Developments
  • Education
  • Find an Accountant
  • Find a Partner
  • Become a Partner
About us
  • Our company
  • Brand Assets
  • Contact us
  • Jobs
  • Events
  • Podcast
  • Blog
  • Customers
  • Legal • Privacy
  • Security
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk Slovenščina Español (América Latina) Español Svenska ภาษาไทย Türkçe українська Tiếng Việt

Odoo is a suite of open source business apps that cover all your company needs: CRM, eCommerce, accounting, inventory, point of sale, project management, etc.

Odoo's unique value proposition is to be at the same time very easy to use and fully integrated.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now