Skip to Content
Odoo Menú
  • Registra entrada
  • Prova-ho gratis
  • Aplicacions
    Finances
    • Comptabilitat
    • Facturació
    • Despeses
    • Full de càlcul (IA)
    • Documents
    • Signatura
    Vendes
    • CRM
    • Vendes
    • Punt de venda per a botigues
    • Punt de venda per a restaurants
    • Subscripcions
    • Lloguer
    Imatges de llocs web
    • Creació de llocs web
    • Comerç electrònic
    • Blog
    • Fòrum
    • Xat en directe
    • Aprenentatge en línia
    Cadena de subministrament
    • Inventari
    • Fabricació
    • PLM
    • Compres
    • Manteniment
    • Qualitat
    Recursos humans
    • Empleats
    • Reclutament
    • Absències
    • Avaluacions
    • Recomanacions
    • Flota
    Màrqueting
    • Màrqueting Social
    • Màrqueting per correu electrònic
    • Màrqueting per SMS
    • Esdeveniments
    • Automatització del màrqueting
    • Enquestes
    Serveis
    • Projectes
    • Fulls d'hores
    • Servei de camp
    • Suport
    • Planificació
    • Cites
    Productivitat
    • Converses
    • Artificial Intelligence
    • IoT
    • VoIP
    • Coneixements
    • WhatsApp
    Aplicacions de tercers Odoo Studio Plataforma d'Odoo al núvol
  • Sectors
    Comerç al detall
    • Llibreria
    • Botiga de roba
    • Botiga de mobles
    • Botiga d'ultramarins
    • Ferreteria
    • Botiga de joguines
    Food & Hospitality
    • Bar i pub
    • Restaurant
    • Menjar ràpid
    • Guest House
    • Distribuïdor de begudes
    • Hotel
    Immobiliari
    • Agència immobiliària
    • Estudi d'arquitectura
    • Construcció
    • Property Management
    • Jardineria
    • Associació de propietaris de béns immobles
    Consultoria
    • Empresa comptable
    • Partner d'Odoo
    • Agència de màrqueting
    • Bufet d'advocats
    • Captació de talent
    • Auditoria i certificació
    Fabricació
    • Textile
    • Metal
    • Mobles
    • Menjar
    • Brewery
    • Regals corporatius
    Salut i fitness
    • Club d'esport
    • Òptica
    • Centre de fitness
    • Especialistes en benestar
    • Farmàcia
    • Perruqueria
    Trades
    • Servei de manteniment
    • Hardware i suport informàtic
    • Sistemes d'energia solar
    • Shoe Maker
    • Serveis de neteja
    • Instal·lacions HVAC
    Altres
    • Nonprofit Organization
    • Agència del medi ambient
    • Lloguer de panells publicitaris
    • Fotografia
    • Lloguer de bicicletes
    • Distribuïdors de programari
    Browse all Industries
  • Comunitat
    Aprèn
    • Tutorials
    • Documentació
    • Certificacions
    • Formació
    • Blog
    • Pòdcast
    Potenciar l'educació
    • Programa educatiu
    • Scale-Up! El joc empresarial
    • Visita Odoo
    Obtindre el programari
    • Descarregar
    • Comparar edicions
    • Novetats de les versions
    Col·laborar
    • GitHub
    • Fòrum
    • Esdeveniments
    • Traduccions
    • Converteix-te en partner
    • Services for Partners
    • Registra la teva empresa comptable
    Obtindre els serveis
    • Troba un partner
    • Troba un comptable
    • Contacta amb un expert
    • Serveis d'implementació
    • Referències del client
    • Suport
    • Actualitzacions
    Github Youtube Twitter Linkedin Instagram Facebook Spotify
    +1 (650) 691-3277
    Programar una demo
  • Preus
  • Ajuda
You need to be registered to interact with the community.
All Posts People Badges
Etiquetes (View all)
odoo accounting v14 pos v15
About this forum
You need to be registered to interact with the community.
All Posts People Badges
Etiquetes (View all)
odoo accounting v14 pos v15
About this forum
Ajuda

infinite loop with on_change?

Subscriure's

Get notified when there's activity on this post

This question has been flagged
on_change
5 Respostes
14494 Vistes
Avatar
vgze

Hello, I try add a on_change on two fields (fields A and fields B). I wand that:

  • if user change the fields A that aumaticaly change the fileds B.
  • if user change the fields B that aumaticaly change the fileds A.

I take the 2 events and they work. But when I launch theim together, infinite loop.

It is possible to take what I want to do?

edit:

sale_perso.py:

def price_unit_change(self, cr, uid, ids, price_unit, product):
    result = {}
    if product:
        product_obj = self.pool.get('product.product')
        product_obj = product_obj.browse(cr, uid, product)
        result['coeff'] = price_unit / product_obj.standard_price 
    return {'value': result}

def coeff_change(self, cr, uid, ids, coeff, standard_price):
    result = {}
    result['price_unit'] = coeff * standard_price
    return {'value': result}

sale_perso_view.xml: <openerp> <data>

    <record model="ir.ui.view" id="sale_order_line_type_price">
        <field name="name">sale.order.line.type.price</field>
        <field name="model">sale.order</field>
        <field name="inherit_id" ref="sale.view_order_form"/>
        <field name="arch" type="xml">
           <xpath expr="//field[@name='order_line']/tree//field[@name='price_unit']" position="replace">
                <field name="price_unit"  on_change="price_unit_change(price_unit, product_id)"/>
           </xpath>
           <xpath expr="//field[@name='order_line']/tree//field[@name='price_unit']" position="before">
                <field name="standard_price"/>
                <field name="coeff"  on_change="coeff_change(coeff, standard_price)"/>
            </xpath>
        </field>
    </record>
</data>
</openerp>
0
Avatar
Descartar
ainur rofiq

fields A and B will always have the same value.
on_change event is triggered when focused loses, pressing TAB or ENTER.
Please post your on_change method and XML on_change field. thanks

ainur rofiq

When you change A then on_change(A) is triggered to change B = A. Now B is changed, then on_changed(B) is triggered to change A. At this point there is no change for A, so on_change(A) is not triggered. So there is no infinite loop.

Avatar
Adrian Merrall
Best Answer

Hi,

If you have an on_change on field A that returns

{'value': {'B': new_value,},}

This will then trigger an on_change on B and if this returns

{'value': {'A': new_value,},}

which will trigger the on_change on A and around we go.

A couple of thoughts here:

  1. 6.1 or older, add a hidden field to the form and pass/return that into the on_change events so your on_change event terminates if the hidden field is set.
  2. Version 7 - use the context. In on_change A, set a flag in the context to say it has just run. In the on_change for B, if the flag is in the context, remote it and terminate rather than re-setting A.

In Version 7, just pass the context in your XML like this:

<field name="A" on_change="a_change(A, context) />

HTH,

Adrian, Auckland, NZ

enter code here
1
Avatar
Descartar
Avatar
vgze
Autor Best Answer

I never used the context dictionnary. I try but, the problem is still here.

sale_perso.py:

def price_unit_change(self, cr, uid, ids, price_unit, product, context):
    result = {}
    lang = context.get('lang',False)
    if context.get('cancel_event',False):
        context = {'lang': lang, 'cancel_event': False}
    else:
        context = {'lang': lang, 'cancel_event': True}
        if product:
            product_obj = self.pool.get('product.product')
            product_obj = product_obj.browse(cr, uid, product)
            result['coeff'] = price_unit / product_obj.standard_price 
    return {'value': result}

def coeff_change(self, cr, uid, ids, coeff, product, context):
    result = {}
    lang = context.get('lang',False)
    if context.get('cancel_event',False):
        context = {'lang': lang, 'cancel_event': False}
    else:
        context = {'lang': lang, 'cancel_event': True}
        if product:
            product_obj = self.pool.get('product.product')
            product_obj = product_obj.browse(cr, uid, product)
            result['price_unit'] = coeff * product_obj.standard_price 
    return {'value': result}

sale_perso_view.xml:

  <?xml version="1.0"?>
    <openerp>
    <data>
       <record model="ir.ui.view" id="sale_order_line_type_price">
        <field name="name">sale.order.line.type.price</field>
        <field name="model">sale.order</field>
        <field name="inherit_id" ref="sale.view_order_form"/>
        <field name="arch" type="xml">
           <xpath expr="//field[@name='order_line']/tree//field[@name='price_unit']" position="replace">
                <field name="price_unit"  on_change="price_unit_change(price_unit, product_id, context)"/>
            </xpath>
           <xpath expr="//field[@name='order_line']/tree//field[@name='price_unit']" position="after">
                <field name="type_price"/>
            </xpath>
           <xpath expr="//field[@name='order_line']/tree//field[@name='price_unit']" position="before">
                <field name="list_price"/>
                <field name="prixmat"/>
                <field name="standard_price"/>
                <field name="coeff"  on_change="coeff_change(coeff, product_id, context)"/>
            </xpath>
           <xpath expr="//field[@name='order_line']/tree//field[@name='name']" position="after">
                <field name="marque"/>
            </xpath>
        </field>
    </record>
    </data>
    </openerp>
0
Avatar
Descartar
Avatar
Christophe Combelles
Best Answer

Hi, I was able to reproduce the issue an found no obvious way to do so. So I entered a new bug report #1203343 (sorry, no "karma" to post the full link :-/)

0
Avatar
Descartar
Avatar
Edison Ibáñez
Best Answer

I had the same problem, solved it updating the context before checking if the previous value was modified

def onchange_comision_value(self, cr, uid, ids, comision, context):
    res = {}
    ctx = dict(context)
    ctx.update
    if context.get('cancel_event', False):
        ctx.update({'cancel_event': False,})
    else:
        ctx.update({'cancel_event': True,})
        for i in self.browse(cr,uid,ids):
            aux_percent = ( comision * 100 ) / i.amount_untaxed
            res['comision_percent'] = aux_percent
    return {'value': res}

def onchange_comision_percent(self, cr, uid, ids, comision_percent, context):
    res = {}
    ctx = dict(context)
    ctx.update
    if context.get('cancel_event', False):
        ctx.update({'cancel_event': False,})
    else:
        ctx.update({'cancel_event': True,})
        for i in self.browse(cr,uid,ids):
            aux_comision = ( i.amount_untaxed * comision_percent ) / 100
            res['comision'] = aux_comision
    return {'value': res}

<field name='comision_percent' class="oe_custom_input  oe_inline" nolabel="1" on_change="onchange_comision_percent(comision_percent, context)" /> %% 
 <field name='comision' string='Comision' class="oe_inline" widget='monetary' options="{'currency_field': 'currency_id'}" on_change="onchange_comision_value(comision, context)" />

I hope that even you need

Greetings.

0
Avatar
Descartar
Avatar
Edison Ibáñez
Best Answer

the solution for your problem, here in the module fleet epecificamente in part:

    def on_change_liter(self, cr, uid, ids, liter, price_per_liter, amount, context=None):
    #need to cast in float because the value receveid from web client maybe an integer (Javascript and JSON do not
    #make any difference between 3.0 and 3). This cause a problem if you encode, for example, 2 liters at 1.5 per
    #liter => total is computed as 3.0, then trigger an onchange that recomputes price_per_liter as 3/2=1 (instead
    #of 3.0/2=1.5)
    #If there is no change in the result, we return an empty dict to prevent an infinite loop due to the 3 intertwine
    #onchange. And in order to verify that there is no change in the result, we have to limit the precision of the 
    #computation to 2 decimal
    liter = float(liter)
    price_per_liter = float(price_per_liter)
    amount = float(amount)
    if liter > 0 and price_per_liter > 0 and round(liter*price_per_liter,2) != amount:
        return {'value' : {'amount' : round(liter * price_per_liter,2),}}
    elif amount > 0 and liter > 0 and round(amount/liter,2) != price_per_liter:
        return {'value' : {'price_per_liter' : round(amount / liter,2),}}
    elif amount > 0 and price_per_liter > 0 and round(amount/price_per_liter,2) != liter:
        return {'value' : {'liter' : round(amount / price_per_liter,2),}}
    else :
        return {}

def on_change_price_per_liter(self, cr, uid, ids, liter, price_per_liter, amount, context=None):
    #need to cast in float because the value receveid from web client maybe an integer (Javascript and JSON do not
    #make any difference between 3.0 and 3). This cause a problem if you encode, for example, 2 liters at 1.5 per
    #liter => total is computed as 3.0, then trigger an onchange that recomputes price_per_liter as 3/2=1 (instead
    #of 3.0/2=1.5)
    #If there is no change in the result, we return an empty dict to prevent an infinite loop due to the 3 intertwine
    #onchange. And in order to verify that there is no change in the result, we have to limit the precision of the 
    #computation to 2 decimal
    liter = float(liter)
    price_per_liter = float(price_per_liter)
    amount = float(amount)
    if liter > 0 and price_per_liter > 0 and round(liter*price_per_liter,2) != amount:
        return {'value' : {'amount' : round(liter * price_per_liter,2),}}
    elif amount > 0 and price_per_liter > 0 and round(amount/price_per_liter,2) != liter:
        return {'value' : {'liter' : round(amount / price_per_liter,2),}}
    elif amount > 0 and liter > 0 and round(amount/liter,2) != price_per_liter:
        return {'value' : {'price_per_liter' : round(amount / liter,2),}}
    else :
        return {}

def on_change_amount(self, cr, uid, ids, liter, price_per_liter, amount, context=None):
    #need to cast in float because the value receveid from web client maybe an integer (Javascript and JSON do not
    #make any difference between 3.0 and 3). This cause a problem if you encode, for example, 2 liters at 1.5 per
    #liter => total is computed as 3.0, then trigger an onchange that recomputes price_per_liter as 3/2=1 (instead
    #of 3.0/2=1.5)
    #If there is no change in the result, we return an empty dict to prevent an infinite loop due to the 3 intertwine
    #onchange. And in order to verify that there is no change in the result, we have to limit the precision of the 
    #computation to 2 decimal
    liter = float(liter)
    price_per_liter = float(price_per_liter)
    amount = float(amount)
    if amount > 0 and liter > 0 and round(amount/liter,2) != price_per_liter:
        return {'value': {'price_per_liter': round(amount / liter,2),}}
    elif amount > 0 and price_per_liter > 0 and round(amount/price_per_liter,2) != liter:
        return {'value': {'liter': round(amount / price_per_liter,2),}}
    elif liter > 0 and price_per_liter > 0 and round(liter*price_per_liter,2) != amount:
        return {'value': {'amount': round(liter * price_per_liter,2),}}
    else :
        return {}

there is this doing the same thing you wantthe solution for your problem, here in the fleet module

0
Avatar
Descartar
Enjoying the discussion? Don't just read, join in!

Create an account today to enjoy exclusive features and engage with our awesome community!

Registrar-se
Related Posts Respostes Vistes Activitat
How to use On change function? Solved
on_change
Avatar
Avatar
Avatar
Avatar
10
de juny 16
35446
Lines Functional values how to shows before saving the record
on_change
Avatar
Avatar
1
d’oct. 15
11205
Two on_change methods for the same field
on_change
Avatar
Avatar
4
d’ag. 15
5469
How to make an on_change event for a one2many related field
on_change
Avatar
Avatar
1
de març 15
6313
how to use on_change attribute ?
on_change
Avatar
1
de març 15
5570
Community
  • Tutorials
  • Documentació
  • Fòrum
Codi obert
  • Descarregar
  • GitHub
  • Runbot
  • Traduccions
Serveis
  • Allotjament a Odoo.sh
  • Suport
  • Actualització
  • Desenvolupaments personalitzats
  • Educació
  • Troba un comptable
  • Troba un partner
  • Converteix-te en partner
Sobre nosaltres
  • La nostra empresa
  • Actius de marca
  • Contacta amb nosaltres
  • Llocs de treball
  • Esdeveniments
  • Pòdcast
  • Blog
  • Clients
  • Informació legal • Privacitat
  • Seguretat
الْعَرَبيّة Català 简体中文 繁體中文 (台灣) Čeština Dansk Nederlands English Suomi Français Deutsch हिंदी Bahasa Indonesia Italiano 日本語 한국어 (KR) Lietuvių kalba Język polski Português (BR) română русский язык Slovenský jazyk Slovenščina Español (América Latina) Español Svenska ภาษาไทย Türkçe українська Tiếng Việt

Odoo és un conjunt d'aplicacions empresarials de codi obert que cobreix totes les necessitats de la teva empresa: CRM, comerç electrònic, comptabilitat, inventari, punt de venda, gestió de projectes, etc.

La proposta única de valor d'Odoo és ser molt fàcil d'utilitzar i estar totalment integrat, ambdues alhora.

Website made with

Odoo Experience on YouTube

1. Use the live chat to ask your questions.
2. The operator answers within a few minutes.

Live support on Youtube
Watch now